Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closes #116] Create a patients details page #149

Merged
merged 23 commits into from
Nov 7, 2024
Merged

[Closes #116] Create a patients details page #149

merged 23 commits into from
Nov 7, 2024

Conversation

samau3
Copy link
Contributor

@samau3 samau3 commented Oct 29, 2024

Closes #116.

This PR adds a page that gives more detailed information about a patient's profile.

image

@samau3 samau3 marked this pull request as ready for review October 29, 2024 23:34
@samau3 samau3 requested a review from francisli October 29, 2024 23:35
Copy link
Contributor

@francisli francisli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's add the QR code (at least on desktop)

@samau3 samau3 requested a review from francisli November 2, 2024 00:18
@samau3 samau3 marked this pull request as draft November 2, 2024 00:22
@samau3 samau3 marked this pull request as ready for review November 2, 2024 00:29
@samau3
Copy link
Contributor Author

samau3 commented Nov 2, 2024

Looks good, let's add the QR code (at least on desktop)

Just added the QR code! I made the size smaller than default the default 150px, but found that going smaller than 100px made the QR code not scannable on a phone.

@francisli
Copy link
Contributor

@samau3 the QR code was still too small for me to scan well, so I've updated the layout a bit so that we can show a bigger QR code... and I'm hiding it on smaller devices (i.e. if you're on a phone already, do you need the code?).

@francisli francisli merged commit 14b8ad5 into dev Nov 7, 2024
1 check passed
@francisli francisli deleted the issue-116 branch November 7, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin/Staff/Volunteer/First Responder can view a Patient record
2 participants